Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test: for lexeme download cmd in CLI and Fix typo #530

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

axif0
Copy link
Collaborator

@axif0 axif0 commented Dec 19, 2024

Contributor checklist


Description

  • Added tests for for lexeme download cmd in CLI
  • Fix typo in file URL construction in download_wd_lexeme_dump function

Related issue

Copy link

github-actions bot commented Dec 19, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@axif0 axif0 requested a review from andrewtavis December 19, 2024 17:00
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great additions to the testing suite, @axif0! Really awesome to have the tests of the new functionality being added as we go 😊

@andrewtavis andrewtavis merged commit dd50d8d into scribe-org:main Dec 19, 2024
5 checks passed
@axif0 axif0 deleted the total_trans branch December 20, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants