-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/optimize workflows #508
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
@andrewtavis any thoughts on how to test the changes? The 5 workflows all run because this change has not been integrated yet. I'm thinking of how we can test this before we merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was to test, but it is not working because this PR has not been merged.
I think the problem is that we are removing most of: push:
branches: [main]
pull_request:
branches: [main]
types: [opened, reopened, synchronize] Is it possible that we just add in the paths and leave |
Without all of |
hmm...interesting point. I will make an update asap. It should be possible... |
@andrewtavis I have done some tests and it works. but please verify. This is a commit where I did not do anything on the metadata or sparql files This is a commit where I adjusted a sparql file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, @DeleMike! Thanks for the quick work here and the documentation of the workflows in action 🚀 Looking forward to coming PRs where we can save some time/minutes in the actions!
Nicee!! @andrewtavis! Looking forward to it too! |
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR ensures that workflows in your repository only run when relevant files or conditions are met, reducing unnecessary runs, saving computation time
Related issue