Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/optimize workflows #508

Merged
merged 7 commits into from
Nov 17, 2024
Merged

Conversation

DeleMike
Copy link
Contributor

Contributor checklist


Description

This PR ensures that workflows in your repository only run when relevant files or conditions are met, reducing unnecessary runs, saving computation time

Related issue

Copy link

github-actions bot commented Nov 17, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@DeleMike
Copy link
Contributor Author

@andrewtavis any thoughts on how to test the changes? The 5 workflows all run because this change has not been integrated yet. I'm thinking of how we can test this before we merge

@andrewtavis andrewtavis self-requested a review November 17, 2024 16:56
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was to test, but it is not working because this PR has not been merged.

@andrewtavis
Copy link
Member

I think the problem is that we are removing most of:

push:
    branches: [main]

pull_request:
    branches: [main]
    types: [opened, reopened, synchronize]

Is it possible that we just add in the paths and leave branches and types above?

@andrewtavis
Copy link
Member

Without all of [opened, reopened, synchronize] it will only run on the first commit of the PR, not further ones.

@DeleMike
Copy link
Contributor Author

I think the problem is that we are removing most of:

push:
    branches: [main]

pull_request:
    branches: [main]
    types: [opened, reopened, synchronize]

Is it possible that we just add in the paths and leave branches and types above?

hmm...interesting point. I will make an update asap. It should be possible...

@DeleMike
Copy link
Contributor Author

DeleMike commented Nov 17, 2024

@andrewtavis I have done some tests and it works. but please verify.


This is a commit where I did not do anything on the metadata or sparql files

Screenshot 2024-11-17 at 18 49 47



This is a commit where I adjusted a sparql file

Screenshot 2024-11-17 at 19 02 16

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, @DeleMike! Thanks for the quick work here and the documentation of the workflows in action 🚀 Looking forward to coming PRs where we can save some time/minutes in the actions!

@andrewtavis andrewtavis merged commit 0cd4cd3 into scribe-org:main Nov 17, 2024
5 checks passed
@DeleMike
Copy link
Contributor Author

Nicee!! @andrewtavis! Looking forward to it too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants