-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional QID order validation and refactor label decomposition #507
Add optional QID order validation and refactor label decomposition #507
Conversation
- Introduced check_optional_qid_order function to validate the order of QIDs in optional statements within SPARQL queries. - Extracted label decomposition logic into the decompose_label_features function, which is now used in both functions. - Updated check_query_forms to include validation for the correct order of QIDs in OPTIONAL clauses.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Wonderful work, @OmarAI2003! 🚀 Can we change the message to |
I've done this. Thanks @andrewtavis for your instant reply. Should I include anything else? |
I'll correct my own suggestion 😇 Let's do |
…rammatical features), update error message, and fix queries.
Good for a final review here, @OmarAI2003? :) |
Yeah, I think so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really amazing work here, @OmarAI2003 😊 No changes needed :) Thanks for the quick reactions to comments and for the attention to detail!
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR introduces a new function
check_optional_qid_order
to validate the order of QIDs in optional statements within SPARQL queries. Additionally, the label decomposition logic has been refactored into thedecompose_label_features
function, which is now used in bothcheck_forms_order
andcheck_optional_qid_order
for better readability and consistency. Thecheck_query_forms
function has been updated to include validation for the correct order of QIDs in OPTIONAL clauses.Note: The queries are still in progress and will be finalized once the function is approved.
Related issue