Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new function to validate the order of variables in SPARQL base… #503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OmarAI2003
Copy link
Contributor

…d on our lexeme_forms_json file

Contributor checklist


Description

This PR introduces a new function, check_forms_order, which orders column names based on the lexeme_forms json fie. The checks the variables returned against the ground truth file, and sorts them accordingly.

Changes:

  • New Function: sort_columns_by_reference implemented to handle the sorting of column names, ensuring correct ordering based on predefined criteria.
  • Integration: integrated The function with the main validation function of the file

The SELECT clause will be ordered hierarchically:

  1. Data type will be the first variable (if it's there).
  2. Variable length (shortest first).
  3. Lexicographical order within each length group, based on a predefined JSON list.
  4. Variables not in the JSON file like those returned by the query service will be added at the end.

Note:
The SPARQL queries diagnosed by this function have not been modified yet so checks will fail. Once the function is agreed upon I will fix and push

Related issue

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review November 1, 2024 22:10
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants