Adds a new function to validate the order of variables in SPARQL base… #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d on our lexeme_forms_json file
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR introduces a new function,
check_forms_order
, which orders column names based on the lexeme_forms json fie. The checks the variables returned against the ground truth file, and sorts them accordingly.Changes:
sort_columns_by_reference
implemented to handle the sorting of column names, ensuring correct ordering based on predefined criteria.The SELECT clause will be ordered hierarchically:
Note:
The SPARQL queries diagnosed by this function have not been modified yet so checks will fail. Once the function is agreed upon I will fix and push
Related issue