-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration - Lowered the languages once in main, and remove from other places, but capitalize for print statements #502
Conversation
…alize for print statements
…alize for print statements
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Are you able to check out the Pytest issues and fix them, @SethiShreya? It may be that the tests need to be rewritten given these changes :) |
Let me complete it first then i will see that too |
Ok fantastic :) Looking forward! |
I'll be cleaning this up to merge, @SethiShreya :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great to have this done, @SethiShreya! 🚀 Really simplifies the code so much 😊 Appreciate your continued suggestions for the project!
Signed off by Shreya Sethi
[email protected]
This PR addresses the issue #446, this PR include:
Tested all the commands on my end, as for total I have tested by first removing all the languages which has sub_languages and everything is working fine.