Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration - Lowered the languages once in main, and remove from other places, but capitalize for print statements #502

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

SethiShreya
Copy link
Contributor

Signed off by Shreya Sethi
[email protected]

This PR addresses the issue #446, this PR include:

  • lowered the language once in main.py
  • remove all the lower functions on the other files
  • capitalize for print statements

Tested all the commands on my end, as for total I have tested by first removing all the languages which has sub_languages and everything is working fine.

Copy link

github-actions bot commented Oct 31, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Are you able to check out the Pytest issues and fix them, @SethiShreya? It may be that the tests need to be rewritten given these changes :)

@andrewtavis andrewtavis self-requested a review October 31, 2024 19:19
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 31, 2024
@SethiShreya
Copy link
Contributor Author

Let me complete it first then i will see that too

@andrewtavis
Copy link
Member

Ok fantastic :) Looking forward!

@andrewtavis
Copy link
Member

I'll be cleaning this up to merge, @SethiShreya :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great to have this done, @SethiShreya! 🚀 Really simplifies the code so much 😊 Appreciate your continued suggestions for the project!

@andrewtavis andrewtavis merged commit d8c3f4c into scribe-org:main Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants