Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check query forms #485

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

VNW22
Copy link
Contributor

@VNW22 VNW22 commented Oct 25, 2024

Contributor checklist


Description

I have added the checks for whitespaces before comma and non white spaces before period and semi colon.
I noticed that in the check correct label when generating QID (return f"{qid_label} {', '.join(not_included_qids)} not included in lexeme_form.metadata.json") where elements are separated by {', '} , because there is no whitespace before the comma, it would print "not included in lexeme_form.metadata.json" eventhough the QID is in the Lexeme_form, when its just a panctuation error.

Related issue

  • #ISSUE_NUMBER

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified the regexes a bit, @VNW22, but aside from that all's great! Thanks so much for this 😊

@andrewtavis andrewtavis merged commit 86676b0 into scribe-org:main Oct 25, 2024
7 checks passed
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants