-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(New) Fixed pyICU capabilities for emoji functionalities #480
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
@andrewtavis I'm not sure @SethiShreya changes in plurals_to_singulars_dict. So I didn't add them. And others I think we might not need to integrate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @axif0! This is really taking the Windows workflow to a level that couldn't have been expected 😊
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
When user gives
scribe-data get --lang english -dt emoji_keywords
command, code will check if pyICU installed or not.we can test using
pip uninstall pyICU
.Related issue
we can close this old PR