Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(New) Fixed pyICU capabilities for emoji functionalities #480

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

axif0
Copy link
Collaborator

@axif0 axif0 commented Oct 24, 2024

Contributor checklist


Description

When user gives scribe-data get --lang english -dt emoji_keywords command, code will check if pyICU installed or not.
we can test using pip uninstall pyICU.

image

Related issue

we can close this old PR

Copy link

github-actions bot commented Oct 24, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 24, 2024 20:13
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 24, 2024
@andrewtavis
Copy link
Member

Is there anything we need to integrate from #406 into here, @axif0?

@axif0
Copy link
Collaborator Author

axif0 commented Oct 24, 2024

@andrewtavis I'm not sure @SethiShreya changes in plurals_to_singulars_dict. So I didn't add them. And others I think we might not need to integrate.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @axif0! This is really taking the Windows workflow to a level that couldn't have been expected 😊

@andrewtavis andrewtavis merged commit 328d916 into scribe-org:main Oct 24, 2024
7 checks passed
@axif0 axif0 deleted the pyICU branch October 26, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants