-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify cli list tests output check #447
Simplify cli list tests output check #447
Conversation
…ynamic spacing and improved test coverage - Implement dynamic spacing for language, ISO, and QID columns in both functions. - Update unit tests to verify header formatting and first language entry dynamically for each function. - Enhance total print call count validation to ensure accuracy.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Once #472 is merged, this PR will require additional commits to incorporate the new formatting updates in the CLI list file. @andrewtavis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing these, @OmarAI2003! Glad to not have to update this all the time :)
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription:
This issue addresses the need to improve the
list_languages
andlist_languages_for_data_type
functions in the CLI. The following changes was implemented:Dynamic Spacing: Modify both functions to use dynamic column widths for displaying languages, ISO codes, and QIDs, ensuring proper alignment regardless of the data.
Improved Unit Tests: Update the unit tests to:
Related issue