Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing file check function #432

Merged
merged 5 commits into from
Oct 19, 2024
Merged

Conversation

axif0
Copy link
Collaborator

@axif0 axif0 commented Oct 18, 2024

Contributor checklist


Description

Added check_missing_query_files function in check_project_structure.py github action to check all missing data-type query for all available language.

Related issue

Copy link

github-actions bot commented Oct 18, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 18, 2024
@andrewtavis andrewtavis self-requested a review October 19, 2024 12:57
"""
Check if a data-type folder contains at least one .sparql file.

Args:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axif0 Can you please remember to format your docstrings in a way that's consistent with the rest of the project. As it's written this won't be parsed into the documentation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this. And thank you. I will remember this in future.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this is really good, @axif0 :) Thanks for it. Please do note the docstrings in the future as with that this review would be pretty effortless. As you can see I commented the checks out for now as we're not close to being able to not have them commented, but we can get to it later 😊

@andrewtavis andrewtavis merged commit 48dd2d8 into scribe-org:main Oct 19, 2024
5 checks passed
@axif0 axif0 deleted the workflowfeat branch October 27, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants