-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed pyICU capabilities for emoji functionalities #407
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,167 @@ | ||
import requests | ||
import pkg_resources | ||
import sys | ||
import os | ||
import platform # Added to check the OS | ||
from pathlib import Path | ||
import subprocess | ||
|
||
|
||
def check_if_pyicu_installed(): | ||
installed_packages = {pkg.key for pkg in pkg_resources.working_set} | ||
if "pyicu" in installed_packages: | ||
return True | ||
return False | ||
|
||
|
||
def get_python_version_and_architecture(): | ||
""" | ||
Get the current Python version and architecture. | ||
|
||
Returns | ||
------- | ||
str : python_version | ||
The Python version in the format 'cpXY'. | ||
str : architecture | ||
The architecture type ('amd64' or 'win32'). | ||
""" | ||
version = sys.version_info | ||
python_version = f"cp{version.major}{version.minor}" | ||
architecture = "win_amd64" if sys.maxsize > 2**32 else "win32" | ||
return python_version, architecture | ||
|
||
|
||
def fetch_wheel_releases(): | ||
""" | ||
Fetch the release data for PyICU from GitHub. | ||
|
||
Returns | ||
------- | ||
list : available_wheels | ||
A list of tuples containing wheel file names and their download URLs. | ||
""" | ||
url = "https://api.github.com/repos/cgohlke/pyicu-build/releases" | ||
response = requests.get(url) | ||
response.raise_for_status() # Raise an error for bad responses | ||
|
||
available_wheels = [] | ||
for release in response.json(): | ||
for asset in release["assets"]: | ||
if asset["name"].endswith(".whl"): | ||
available_wheels.append((asset["name"], asset["browser_download_url"])) | ||
|
||
return available_wheels | ||
|
||
|
||
def download_wheel_file(wheel_url, output_dir): | ||
""" | ||
Download the wheel file from the given URL. | ||
|
||
Parameters | ||
---------- | ||
wheel_url : str | ||
The URL of the wheel file to download. | ||
output_dir : str | ||
The directory to save the downloaded file. | ||
|
||
Returns | ||
------- | ||
str : path to the downloaded wheel file. | ||
""" | ||
response = requests.get(wheel_url) | ||
response.raise_for_status() # Raise an error for bad responses | ||
|
||
wheel_filename = os.path.basename(wheel_url) | ||
wheel_path = os.path.join(output_dir, wheel_filename) | ||
|
||
with open(wheel_path, "wb") as wheel_file: | ||
wheel_file.write(response.content) | ||
|
||
return wheel_path | ||
|
||
|
||
def find_matching_wheel(wheels, python_version, architecture): | ||
""" | ||
Find the matching wheel file based on Python version and architecture. | ||
|
||
Parameters | ||
---------- | ||
wheels : list | ||
The list of available wheels. | ||
python_version : str | ||
The Python version (e.g., 'cp311'). | ||
architecture : str | ||
The architecture type (e.g., 'win_amd64'). | ||
|
||
Returns | ||
------- | ||
str : The download URL of the matching wheel or None if not found. | ||
""" | ||
for name, download_url in wheels: | ||
if python_version in name and architecture in name: | ||
return download_url | ||
return None | ||
|
||
|
||
def check_and_install_pyicu(): | ||
""" | ||
Check if PyICU is installed, and if not, download and install it dynamically. | ||
If the OS is not Windows, directly use `pip install PyICU`. | ||
""" | ||
package_name = "PyICU" | ||
|
||
# Check if PyICU is already installed using pkg_resources | ||
installed_packages = {pkg.key for pkg in pkg_resources.working_set} | ||
if package_name.lower() not in installed_packages: | ||
print(f"{package_name} not found. Installing...") | ||
|
||
# Check the operating system | ||
if platform.system() != "Windows": | ||
# If not Windows, directly use pip to install PyICU | ||
try: | ||
subprocess.run( | ||
[sys.executable, "-m", "pip", "install", package_name], check=True | ||
) | ||
print(f"{package_name} has been installed successfully.") | ||
except subprocess.CalledProcessError as e: | ||
print(f"Error occurred while installing {package_name}: {e}") | ||
return False | ||
else: | ||
# Windows-specific installation using wheel files | ||
python_version, architecture = get_python_version_and_architecture() | ||
|
||
# Fetch available wheels from GitHub | ||
wheels = fetch_wheel_releases() | ||
|
||
# Find the matching wheel for the current Python version and architecture | ||
wheel_url = find_matching_wheel(wheels, python_version, architecture) | ||
|
||
if not wheel_url: | ||
print( | ||
"No matching wheel file found for your Python version and architecture." | ||
) | ||
return False | ||
|
||
# Download the wheel file | ||
output_dir = Path.cwd() # Use the current directory for simplicity | ||
wheel_path = download_wheel_file(wheel_url, output_dir) | ||
|
||
# Install PyICU using pip | ||
try: | ||
subprocess.run( | ||
[sys.executable, "-m", "pip", "install", wheel_path], | ||
check=True, | ||
) | ||
print(f"{package_name} has been installed successfully.") | ||
|
||
# Remove the downloaded wheel file | ||
os.remove(wheel_path) | ||
print(f"Removed temporary file: {wheel_path}") | ||
|
||
except subprocess.CalledProcessError as e: | ||
print(f"Error occurred while installing {package_name}: {e}") | ||
return False | ||
else: | ||
print(f"{package_name} is already installed.") | ||
|
||
return True |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a user I would be alarmed if suddenly a package gets auto installed. I think it would be nice to describe in one sentence why installing
PyICU
is needed. WHat do you think @andrewtavis?