Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Italian verbs query #394

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

OkpePhillips
Copy link
Contributor

Contributor checklist


Description

These changes expanded the Italian verb queries to use the new standard format of separate grammatical number (e.g singular) and grammatical person (e.g first person) instead of being combined (e.g first-person-singular) as was the case before.
The verb forms that are being retrieved include:

  • Present Tense: First Person, Second Person and Third Person forms
  • Preterite: First Person, Second Person and Third Person forms
  • Imperfect: First Person, Second Person and Third Person forms

Additional file was created to separate the queries to prevent timeout errors.

The queries have been tested on Wikidata Query Service UI and the outputs are without errors.

Related issue

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing work here, @OkpePhillips! I'll make an issue for us transferring the info from my post on how to write queries into a markdown file. Would be great if you worked on that or at least reviewed!

@andrewtavis andrewtavis merged commit eef5b4c into scribe-org:main Oct 16, 2024
5 checks passed
@OkpePhillips
Copy link
Contributor Author

Sure @andrewtavis , I would love to work on it. Kindly assign the issue to me when you create it.

Thank you for the review

@andrewtavis andrewtavis mentioned this pull request Oct 16, 2024
2 tasks
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants