Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Finnish verb query. #360

Closed
wants to merge 58 commits into from

Conversation

Ebeleokolo
Copy link
Contributor

This PR introduces the SPARQL query that expands the Finnish verb query.

The query was tested using the Wikidata query service.

Any feedback or suggestions are greatly appreciated.

Contributor checklist


Description

Related issue

  • #ISSUE_NUMBER

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 15, 2024
@andrewtavis
Copy link
Member

Workflow is functioning, @axif0! Thanks for it :)

@Ebeleokolo
Copy link
Contributor Author

Hello @andrewtavis, there isn't much data available in Wikidata for Finnish verbs at the moment. Out of the forms I added in the query, only about 7 return results. I could update the query to only include the forms that currently have data, or we can wait for more Finnish verb data to be added in the future. Please let me know your thoughts on this. Thank you

@andrewtavis
Copy link
Member

Hey @Ebeleokolo 👋 It might be best for us to only include the forms that return data for now so that we don't use a modeling strategy that might not be used by the editors :) Can you rework it so only the forms that have data are gotten, and we can then revisit this later? Thank you!

@Ebeleokolo
Copy link
Contributor Author

Hello @andrewtavis, I have removed the forms that don't return data. Kindly check and notify me of any other issues. Thank you.

@andrewtavis
Copy link
Member

@Ebeleokolo, there are now tons of commits on this PR because of some weird branch merging 🤔 Do you want to open a new PR with the new Finnish verbs query just by itself after pulling from main to your fork/branch?

As it is I wouldn't be able to review this, so would be great if you open a new PR or fix the commits here!

@andrewtavis
Copy link
Member

Closing this as the work was done in #398. Thanks @Ebeleokolo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants