-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Finnish verb query. #360
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.email
in their local Scribe-Data repo
for adverb
adverb for Pidgin/Nigerian
Create query_adverbs.sparql
Create query_adverbs.sparql
Workflow is functioning, @axif0! Thanks for it :) |
adverbs for yoruba
adverb for chinese/mandarin
adverb for english
adverb for Tajik
Creating emoji_keywords
Adverb for Basque
Create query_adverbs.sparql
Create query_adverbs.sparql
…ons-Czech Added Data For Czech Language
Tamil adverbs
fix lists of arguments to be validated
add workflow check_query_identifiers and dummy script scribe-org#339
Hello @andrewtavis, there isn't much data available in Wikidata for Finnish verbs at the moment. Out of the forms I added in the query, only about 7 return results. I could update the query to only include the forms that currently have data, or we can wait for more Finnish verb data to be added in the future. Please let me know your thoughts on this. Thank you |
Hey @Ebeleokolo 👋 It might be best for us to only include the forms that return data for now so that we don't use a modeling strategy that might not be used by the editors :) Can you rework it so only the forms that have data are gotten, and we can then revisit this later? Thank you! |
…cribe-Data into expand-finnish-verb
Hello @andrewtavis, I have removed the forms that don't return data. Kindly check and notify me of any other issues. Thank you. |
@Ebeleokolo, there are now tons of commits on this PR because of some weird branch merging 🤔 Do you want to open a new PR with the new Finnish verbs query just by itself after pulling from main to your fork/branch? As it is I wouldn't be able to review this, so would be great if you open a new PR or fix the commits here! |
Closing this as the work was done in #398. Thanks @Ebeleokolo! |
This PR introduces the SPARQL query that expands the Finnish verb query.
The query was tested using the Wikidata query service.
Any feedback or suggestions are greatly appreciated.
Contributor checklist
Description
Related issue