-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Estonian verb data query #345
Estonian verb data query #345
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Hi @andrewtavis i done with the verb queries. It much. I"m done too with the emoji_keyword_generation, only had errors when trying to test of it. I will raise a PR soon |
The queries are coming out a lot nicer, @Ekikereabasi-Nk :) One thing to note is that we really want one row per result. I think that we need so many files in this case because we're getting lots of results duplicated. There should also be no need for |
Alright @andrewtavis will do so. Thank for the feedback |
Hi @andrewtavis, I need your assistance. I need a clearer picture to understand "One thing to note is that we really want one row per result". While learning I came across the SAMPLE keyword commonly used in queries where there may be multiple results for a variable, and you want to reduce those results to one (it fit into the purpose of one row per result and avoid duplicate). But the downside of SAMPLE is selects only one value from the set of possible values, especially in the case of Estonian verb that has multiple valid forms. Should I use it or stick to other keyword like GROUP BY(which has complexity and query error "Unknown error: java.lang.StackOverflowError" . Thank you |
f290659
to
9070c3e
Compare
Hi @andrewtavis I done with the verbs changes. Can I also be assign to python based issues, I'm open to joining a team working on an issue. Thank you |
There's been a lot of progress here, @Ekikereabasi-Nk :) Big thing is that we need to make sure that we have all of the properties on each of the forms, and also that we're getting all of the forms. I'm not seeing third person forms, for instance. Do you want to take a further look into this? |
Aright @andrewtavis I will look at it. Thanks for the feedback |
Feel free to work on the Python for #359 before you jump back over here, @Ekikereabasi-Nk. I know that you want to do Python, so as you wish, but you can take a break from this for now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll bring this in and make the needed edits, @Ekikereabasi-Nk :) Thanks for the contribution!
Contributor checklist
Description
This pull request introduces a set of SPARQL queries that retrieve various Estonian verb forms
I tested the queries in the Wikidata query service