-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to convert data to CSV/TSV and JSON and vice versa. #329
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
… since I previously erroneously named it.
src/scribe_data/cli/main.py
Outdated
"-od", | ||
"--output-dir", | ||
type=Path, | ||
required=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need for this to be required. Ideally the default directories would be used if this isn't included :)
@mhmohona, if you have time, it'd be great if you could take a first look at the changes to |
Hebrew adjectives.
fixing IncompleteRead issue
fix interactive cli command
…into decouple_convert
@john-thuo1, is there a way that we can get the commit history here cleaned up a bit? It's hard for us to review this as I can't tell what the changes are that are in here and already on main. What might make sense would be to make a new branch from the current version of main and add your changes to that? Then open a new PR? |
Alright. Apologies for that. Still getting the hang of cherry-picking. |
Hey it's hard stuff, @john-thuo1! Thanks for opening #338 :) |
Contributor Checklist
Description
This pull request adds functionality to convert data into CSV, TSV, and JSON formats. The changes include:
convert_to_json
andconvert_to_csv_or_tsv
methods inconvert.py
.main.py
to support new conversion commands.Example Commands:
I tested the changes by running the CLI commands and verifying that the output matched the expected formats. I want to get feedback on the approaches before implementing the code tests and the SQLite conversion support
Related issue
convert
fromget
in Scribe-Data CLI #213