-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker image file for CLI #168
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bc961af
add docker
mhmohona 33a7194
Merge branch 'scribe-org:main' into docker
mhmohona 265bb00
Merge branch 'main' into docker
andrewtavis 8d14e76
add ignore file
mhmohona 2be1100
Merge branch 'docker' of https://github.com/mhmohona/Scribe-Data into…
mhmohona fef58bf
Merge branch 'scribe-org:main' into docker
mhmohona d62ccf5
Merge branch 'scribe-org:main' into docker
mhmohona 201f1f5
Merge branch 'scribe-org:main' into docker
mhmohona b2fea2c
Merge branch 'main' into docker
wkyoshida 271db79
refac(docker): Update `Dockerfile` to remove multi-stage
wkyoshida cb29d7b
chore(requirements): Update to remove `tensorflow`
wkyoshida ea15720
Merge branch 'main' into docker
mhmohona dabe56a
Merge branch 'scribe-org:main' into docker
mhmohona 72ad8dd
Merge branch 'scribe-org:main' into docker
mhmohona 669412f
Fix comment formatting for Docker file
andrewtavis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
__pycache__/ | ||
*.pyc | ||
*.pyo | ||
*.pyd | ||
.venv/ | ||
venv/ | ||
.git/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Use an official Python runtime as a base image. | ||
FROM python:slim | ||
|
||
# Set the working directory inside the container. | ||
WORKDIR /app | ||
|
||
# Install system dependencies. | ||
RUN apt-get update && apt-get install -y \ | ||
build-essential \ | ||
pkg-config \ | ||
libicu-dev \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
COPY requirements.txt /app/ | ||
RUN pip install --no-cache-dir -r requirements.txt | ||
|
||
COPY . /app | ||
|
||
# Set the PYTHONPATH environment variable to include the src directory. | ||
ENV PYTHONPATH=/app/src | ||
|
||
# Set the entry point to the main CLI script. | ||
ENTRYPOINT ["python", "src/scribe_data/cli/main.py"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the behavior btw with the saved output files? They just make me wonder we might need a Docker volume to store and retain the output results after the container exits. Are they getting saved inside the container atm? |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a version of the
Dockerfile
wherescribe-data
gets installed instead, as opposed to runningpython ...
? Running viapython
still works tbh though, just wondering if we could make theDockerfile
this way.