Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use cors library to set up CORS handlers for our HTTP servers. In
v1.8.0
introduced backwards-incompatible changes that potentially might break the clients. Thus, it might affect the existing behavior of the web-analytics-ingestion which explicitly checks for 200 status codes returned for pre-flight requests.The spec doesn't tell us what HTTP status to use for prefight responses, but some clients indeed might rely on the
200
status code returned.In order to avoid any potential problems with CORS, as a short-term solution, we downgrade the
cors
library to versionv1.7.0
. As a long-term solution, we raised a PR to the original cors library to provide a way to specify response code for pre-flight requests.Checklist
development
and/orstaging
README.md
as necessaryRelated links