Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each class makes its own directory #1

Closed
jim80net opened this issue Jul 16, 2020 · 0 comments
Closed

Each class makes its own directory #1

jim80net opened this issue Jul 16, 2020 · 0 comments
Assignees
@jim80net

Comments

@jim80net
Copy link
Contributor

https://github.com/scribd/datadog_sync/blob/a06e77a436229d042f133388a1b747b4a1c4ac1e/lib/datadog_sync/core.rb#L49

By using the #myclass method, mkdir_p can just invoke its own directory when class is initialized.
@jim80net jim80net self-assigned this Jul 16, 2020
@jim80net jim80net changed the title Would do just as well to do only each subclass's directory, rather than maintain a list of the subclasses Each class makes its own directory Jul 16, 2020
jim80net added a commit that referenced this issue Aug 17, 2023
@lewhit @jim80net
feat: backup SLOs (#155)
6cca6e7 
* feat: backup SLOs (#1)

* Add specs for slos

* Add SLOs resource

* Update spec/datadog_backup/slos_spec.rb

Co-authored-by: Jim Park <[email protected]>

* Update spec/datadog_backup/slos_spec.rb

Co-authored-by: Jim Park <[email protected]>

* Update spec/datadog_backup/slos_spec.rb

Co-authored-by: Jim Park <[email protected]>

* Go a level deeper for SLOs (do not need data header)

---------

Co-authored-by: Jim Park <[email protected]>
github-actions bot pushed a commit that referenced this issue Aug 17, 2023
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
86f3f64 
# [3.3.0](v3.2.1...v3.3.0) (2023-08-17)

### Features

* backup SLOs ([#155](#155)) ([6cca6e7](6cca6e7)), closes [#1](#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jim80net jim80net

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jim80net