fix: buildLog component set property when component is destroyed #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klu909
previously approved these changes
Feb 28, 2020
jithine
previously approved these changes
Feb 28, 2020
adong
force-pushed
the
adong/fix-build-log-error
branch
from
16adc21 to
048ea18
Compare
klu909
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is kind annoying when UI faces racing condition: when component is getting destroyed while setting property in the component. See screenshot:
Objective
Add
!this.get('isDestroyed') && !this.get('isDestroying')to ensure component is present.References
See other reference:
I'm actually thinking we should integrate with ember-concurrency slowly.
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.