feat(1809): build hyperctl from source. BREAKING CHANGE: hyperctl version will be 1.1.0 from 0.8.1 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk3fftk
force-pushed
the
build-from-source
branch
from
4e651e9 to
2fa1f2d
Compare
tk3fftk
changed the title
tk3fftk
force-pushed
the
build-from-source
branch
from
2fa1f2d to
609beae
Compare
tk3fftk
force-pushed
the
build-from-source
branch
from
609beae to
921ed8a
Compare
tk3fftk
force-pushed
the
build-from-source
branch
from
4343514 to
9d35ce6
Compare
tk3fftk
changed the title
tk3fftk
force-pushed
the
build-from-source
branch
from
8af44e7 to
a903191
Compare
|
I think should rename |
screwdriver.yaml
Outdated
| @@ -1,5 +1,7 @@ | |||
| shared: | |||
| image: centos | |||
| image: golang:1.12 | |||
There was a problem hiding this comment.
Not using latest version is there any reason?
now latest version is 1.13
There was a problem hiding this comment.
I think use latest is also fine.
There was a problem hiding this comment.
Updated image tag and my local golang environment 🙏
| @@ -1,19 +1,21 @@ | |||
| shared: | |||
| image: centos | |||
| image: golang:1.13 | |||
| environment: | |||
There was a problem hiding this comment.
golang version 1.13 do changed GO111MODULE default(auto mode) work.
I think so sould if not using go module function, GO111MODULE expressly set value off.
reference: golang/go#31857
There was a problem hiding this comment.
Thanks, I set GO111MODULE to off explicitly.
sugarnaoming
approved these changes
Oct 23, 2019
jithine
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Binaries of hypercontainer have gone from AWS.
Objective
We build
hyperctlfrom its source. The difference of master and1.1.0is just 2 commits so I use master branch directly.We used
0.8.1but latest version is1.1.0. It may be breaking change for hyperctl-image and we should verify new one.References
Issue: screwdriver-cd/screwdriver#1809
Original build log in Travis CI:
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.