Fixed quite a few issues and removed quite a few un-needed containers. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks looks good! |
tiennou
added a commit
to tiennou/ScreepsGrafanaV2
that referenced
this pull request
Sep 27, 2024
This got disabled by screepers#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Here is what I have changed and fixed:
When pulling from a private server, if the username was an email, and the email had a period, it would add a sub-object in Grafana.
This was fixed by adding the
replaceNameoption to the config, if it is added, theusernameis replaced with whatever is in thereplaceNameattribute.Switch from this container dance to just pure graphite. Makes the compose easier to understand and debugging much easier.
Remove traefik, as it would probably be better for the user to add it themselves.
Fixed the AdminStatsUsers getter, as it was attempting to
forEach((user) => {})over an object. That did not work.Cleaned up the example config files, making it a bit easier to understand.