Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(): update typescript definitions with Promise support #30

Merged
merged 2 commits into from
Apr 26, 2020
Merged

fix(): update typescript definitions with Promise support #30

merged 2 commits into from
Apr 26, 2020

Conversation

micaelmbagira
Copy link
Contributor

@micaelmbagira micaelmbagira commented Apr 23, 2020 •
edited
Loading

#26 introduced Promise support but the typescript definitions were not updated (which means it can't be used in typescript).

Also updated the docs.

@micaelmbagira
Copy link
Contributor Author

@scravy hopefully we can get this one merged soon since 4.0 broke TS support 🙂

@scravy scravy merged commit 8dd2d30 into scravy:master Apr 26, 2020
@scravy
Copy link
Owner

scravy commented Apr 26, 2020

Has been released as 0.4.1: https://github.com/scravy/node-macaddress/releases/tag/0.4.1

@micaelmbagira micaelmbagira mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micaelmbagira @scravy