-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create New Modal Component #980
Comments
Global content for modal: Tutorial: Activity Cards: Educator Guide: |
(Note: we updated the text above.) |
@ntlrsk - What do you think of the banner images? |
Those look great! The two I had questions about are Let's Dance and the Story one. (1) For dance I wonder if it would be good to show different poses of the same dancers (like how Pong has animation)? (2) And for story either totally different characters each time, or more of a story progression? I can provide if that's helpful! |
@ntlrsk - Thanks for the notes.
Super easy to update! |
Here's a possibility for dance as one big image - Champ99 in four dance positions across (right now one is hidden in this project): https://scratch.mit.edu/projects/129601771/#editor |
Or if we want the Dance project to look more like the sample project, a similar idea but with our other character ( like this https://scratch.mit.edu/projects/129516330/#editor ) |
@ntlrsk - I updated my previous comment
|
@carljbowman |
One more minor question -was wondering whether to have the medium haircut for the Fashion Game. Excited to see these on the site! |
1. Split out base modal stylings from iframe modal stylings 2. Move iframe-specific stylings into a separate copmonent 3. Move width/height iframe stylings to scss 4. Change global stylings for modals to match scratchfoundation#980 5. Update styles to use trello style guide
Removed the getting started placeholder. Added all the banners from scratchfoundation#980, updated ttt.json with banner location
Implement GH-980: add new TTT modal component
Implemented in #1008 |
1. Split out base modal stylings from iframe modal stylings 2. Move iframe-specific stylings into a separate copmonent 3. Move width/height iframe stylings to scss 4. Change global stylings for modals to match scratchfoundation#980 5. Update styles to use trello style guide
Implement GH-980: add new TTT modal component
* release/hoc-2016-1: Merge pull request #1027 from TheGrits/patch-7 Additional content changes Fix TTT content Redirect hoc page to `/go` Merge pull request #1037 from chrisgarrity/patch-column-count update ttt content Update ttt content Merge pull request #1006 from chrisgarrity/feature/gh979-tttpage Merge pull request #1018 from mewtaylor/issue/gh-995 Merge pull request #1008 from mewtaylor/issue/gh-980 Update pattern so rewrite accepts querystring too # Conflicts: # src/components/modal/ttt/modal.jsx # src/views/jobs/jobs.jsx # src/views/thingstotry/l10n.json
We currently use
react-modal
to handle some of our modal elements, however it would be nice to have our own modal that can be a bit more customizable to the use cases we need it for. See #979 for a specific, new modal use case. The design for this modal needs to include the following elements:onclickoutside
so that clicking the opaque background closes the modalNeeds a mobile design as well
The text was updated successfully, but these errors were encountered: