Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create New Modal Component #980

Closed
mewtaylor opened this issue Oct 24, 2016 · 13 comments
Closed

Create New Modal Component #980

mewtaylor opened this issue Oct 24, 2016 · 13 comments
Assignees
Labels
Milestone

Comments

@mewtaylor
Copy link
Contributor

We currently use react-modal to handle some of our modal elements, however it would be nice to have our own modal that can be a bit more customizable to the use cases we need it for. See #979 for a specific, new modal use case. The design for this modal needs to include the following elements:

  • An "x" in the top right corner to close the modal (or top left, for rtl)
  • Use onclickoutside so that clicking the opaque background closes the modal
  • Rounded corners
  • A blue opacity for the page behind

Needs a mobile design as well

@carljbowman
Copy link
Contributor

carljbowman commented Oct 25, 2016

r2 0_modal

r2 0_modal grid

@kaschm
Copy link

kaschm commented Nov 2, 2016

Global content for modal:

Tutorial:
Find out how to make this project using a step-by-step tutorial in Scratch.

Activity Cards:
Explore new coding ideas using this set of illustrated cards you can print out.

Educator Guide:
Use this educator guide to plan and lead a one-hour Scratch workshop.

@ntlrsk
Copy link

ntlrsk commented Nov 2, 2016

(Note: we updated the text above.)

@carljbowman
Copy link
Contributor

carljbowman commented Nov 7, 2016

@ntlrsk - What do you think of the banner images?

Animate Your Name
animate-your-name-banner

Make it Fly
make-it-fly-banner

Make Music
make-music-banner

Race to the Finish
race-to-the-finish-banner

Hide and Seek
hide-and-seek-banner

Create a Story
create-a-story-banner

Fashion Game
fashion-game-banner

Pong Game
pong-game-banner

Let's Dance
lets-dance-banner2

Catch Game
catch-game-banner

Virtual Pet
virtual-pet-banner

@ntlrsk
Copy link

ntlrsk commented Nov 7, 2016

Those look great! The two I had questions about are Let's Dance and the Story one. (1) For dance I wonder if it would be good to show different poses of the same dancers (like how Pong has animation)? (2) And for story either totally different characters each time, or more of a story progression? I can provide if that's helpful!

@carljbowman
Copy link
Contributor

carljbowman commented Nov 7, 2016

@ntlrsk - Thanks for the notes.

  1. Let's Dance - Did you have particular dance poses or sequence in mind?
  2. Create a Story - Awesome! Would you mind providing the 3 frames?

Super easy to update!

@ntlrsk
Copy link

ntlrsk commented Nov 7, 2016

Here's a possibility for dance as one big image - Champ99 in four dance positions across (right now one is hidden in this project): https://scratch.mit.edu/projects/129601771/#editor
Similar to this:
image

@ntlrsk
Copy link

ntlrsk commented Nov 8, 2016

Or if we want the Dance project to look more like the sample project, a similar idea but with our other character ( like this https://scratch.mit.edu/projects/129516330/#editor )

image

@ntlrsk
Copy link

ntlrsk commented Nov 8, 2016

For Story how about these three (which we use on the cards):
story1
story3
story4
Or are they too different?

@carljbowman
Copy link
Contributor

@ntlrsk - I updated my previous comment

  1. Let's Dance - There are two versions V1 with Champ & V2 with Jo. Let me know if you have a preference.
  2. Create a Story - We tried to avoid using text in the images for translation purposes, so I did not include the speech bubble.
  3. Animate Your Name - As we discussed yesterday, I changed the name from 'Scratch' back to 'Ana'.

@ntlrsk
Copy link

ntlrsk commented Nov 8, 2016

@carljbowman
Let's go with Jouvi for the dancer
They all look good!

@ntlrsk
Copy link

ntlrsk commented Nov 8, 2016

One more minor question -was wondering whether to have the medium haircut for the Fashion Game. Excited to see these on the site!

mewtaylor added a commit to mewtaylor/scratch-www that referenced this issue Nov 8, 2016
1. Split out base modal stylings from iframe modal stylings
2. Move iframe-specific stylings into a separate copmonent
3. Move width/height iframe stylings to scss
4. Change global stylings for modals to match scratchfoundation#980
5. Update styles to use trello style guide
chrisgarrity added a commit to chrisgarrity/scratch-www that referenced this issue Nov 10, 2016
Removed the getting started placeholder.
Added all the banners from scratchfoundation#980, updated ttt.json with banner location
mewtaylor added a commit that referenced this issue Nov 14, 2016
Implement GH-980: add new TTT modal component
@mewtaylor
Copy link
Contributor Author

Implemented in #1008

chrisgarrity pushed a commit to chrisgarrity/scratch-www that referenced this issue Nov 14, 2016
1. Split out base modal stylings from iframe modal stylings
2. Move iframe-specific stylings into a separate copmonent
3. Move width/height iframe stylings to scss
4. Change global stylings for modals to match scratchfoundation#980
5. Update styles to use trello style guide
mewtaylor added a commit that referenced this issue Nov 18, 2016
Implement GH-980: add new TTT modal component
mewtaylor added a commit that referenced this issue Nov 21, 2016
* release/hoc-2016-1:
  Merge pull request #1027 from TheGrits/patch-7
  Additional content changes
  Fix TTT content
  Redirect hoc page to `/go`
  Merge pull request #1037 from chrisgarrity/patch-column-count
  update ttt content
  Update ttt content
  Merge pull request #1006 from chrisgarrity/feature/gh979-tttpage
  Merge pull request #1018 from mewtaylor/issue/gh-995
  Merge pull request #1008 from mewtaylor/issue/gh-980
  Update pattern so rewrite accepts querystring too

# Conflicts:
#	src/components/modal/ttt/modal.jsx
#	src/views/jobs/jobs.jsx
#	src/views/thingstotry/l10n.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants