[WIP] turn the config into a component of the app #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Digenis
force-pushed
the
config_interface
branch
from
cbf2389
to
d79e8e2
Compare
Current coverage is 68.63% (diff: 100%)@@ master #186 diff @@
==========================================
Files 15 15
Lines 785 794 +9
Methods 0 0
Messages 0 0
Branches 70 70
==========================================
+ Hits 536 545 +9
Misses 225 225
Partials 24 24
|
Digenis
changed the title
|
Closing PR as a 5-year-old work-in-progress. See issue #210. |
jpmckinney
added
pr: abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to make the config a component of the app
so that other components will get the config options directly from it.
This should make scrapyd able to reload the config (eg with a SIGHUP)
without the need to restart.