Fix :nth-*(an+b) pseudo-classes selectors for negative a's #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </head> | ||
| <body> | ||
| <div id="test"> |
There was a problem hiding this comment.
This is a huge diff unrelated to the rest of the commit. Could you avoid touching non-trailing whitespace? Or if you really want to get rid of tabs, please do it in a separate commit.
There was a problem hiding this comment.
sorry, it's my editor default settings. Will clean it up
|
Does that look better? |
|
@SimonSapin , do you think this can be merged? |
|
Please see #48. |
Fix :nth-last-child(1)/:nth-last-of-type(1) translations (fixes #15)
Current coverage is 95.43%@@ master #42 diff @@
==========================================
Files 3 3
Lines 708 723 +15
Methods 0 0
Messages 0 0
Branches 114 121 +7
==========================================
+ Hits 673 690 +17
Misses 19 19
+ Partials 16 14 -2
|
|
Superseded by #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15 and #46
I rewrote
xpath_nth_child_function()to follow the logic I wrote down on paper with simple equations. It's not the nicest code.I also changed the expected result for
li:nth-last-child(2n+2):as I understand the W3C specs, an+b-1 siblings after should return
li's that have 2n+1 siblings after them, soli6, 4 and 2 (of the 7liin the test document)http://www.w3.org/TR/selectors/#nth-last-child-pseudo