Replace s3cmd with awscli #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.34% (diff: 100%)@@ master #6 diff @@
==========================================
Files 1 1
Lines 45 43 -2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43 41 -2
Misses 2 2
Partials 0 0
|
| self._call(cmd) | ||
|
|
||
| def _store_data(self): | ||
| # check for reason status here? | ||
| logger.info('Syncing .scrapy directory to %s' % self._s3path) | ||
| cmd = ['s3cmd', 'sync', '--no-preserve', |
There was a problem hiding this comment.
Looks like awscli doesn't copy FS attributes, so it's fine to just drop no-preserve (aws/aws-cli#1585).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is related with transition to Python 3:
s3cmddoesn't support it and it was decided to replace it withawscli.