Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix option name (ignore-size -> ignore_size) #424

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Fix option name (ignore-size -> ignore_size) #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3515187
Fix option name (ignore-size -> ignore_size)
elacuesta Feb 3, 2023
57cd387
CI: Downgrade ubuntu image for py36 tests
elacuesta Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,28 @@ on:
jobs:
tests-ubuntu:
name: "Test: py${{ matrix.python-version }}, Ubuntu"
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
include:
- python-version: '3.6'
os: ubuntu-20.04
tox-env: min
- python-version: '3.6'
os: ubuntu-20.04
tox-env: py
- python-version: '3.7'
os: ubuntu-latest
tox-env: py
- python-version: '3.8'
os: ubuntu-latest
tox-env: py
- python-version: '3.9'
os: ubuntu-latest
tox-env: py
- python-version: '3.10'
os: ubuntu-latest
tox-env: py

steps:
Expand Down
2 changes: 1 addition & 1 deletion shub/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def make_deploy_request(url, data, files, auth, verbose, keep_log):
def _check_deploy_files_size(files):
"""Ensure that request's files total size is less than current limit."""
ctx = click.get_current_context(silent=True)
if not isinstance(files, list) or ctx and ctx.params.get('ignore-size'):
if not isinstance(files, list) or ctx and ctx.params.get('ignore_size'):
return
files_size = sum(
len(fp) if isinstance(fp, string_types)
Expand Down