Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to deploy project on windows platform #58

Closed
oltarasenko opened this issue Aug 21, 2015 · 1 comment
Closed

Impossible to deploy project on windows platform #58

oltarasenko opened this issue Aug 21, 2015 · 1 comment
Assignees
@josericardo

Comments

@oltarasenko
Copy link

Got an error from user:
capture

The issue was already discussed in another thread.
http://support.scrapinghub.com/topic/808955-windowserror-32-the-process-cannot-access-the-file/

Suggested fix was: "comment out the temporary file removal in the finally block in deploy.py" needs to be tested on windows platform
@josericardo josericardo self-assigned this Aug 21, 2015
josericardo added a commit that referenced this issue Aug 21, 2015
@josericardo
Ignore errors on tmp dir removal on shub deploy
cf1d43c 
A race condition was reported on windows platforms, see issue #58 and
the error on the tmp dir removal was masquerading the real error.

As these folders are usually pretty small and the error only rarely happens on
windows I think that just ignoring the error won't cause trouble to users.
@josericardo
Copy link
Contributor

The errors on the tmp dir removal are now ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josericardo josericardo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oltarasenko @josericardo