Improve remote exception printing

scrapinghub · Feb 29, 2016 · 38bc8b7 · 38bc8b7 · pablohoffman · Feb 29, 2016
1 parent 70601f7
commit 38bc8b7
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/shub/utils.py b/shub/utils.py
@@ -50,7 +50,14 @@ def make_deploy_request(url, data, files, auth, verbose, keep_log):
         if rsp.status_code == 403:
             raise InvalidAuthException
 
-        msg = "Deploy failed ({}):\n{}".format(rsp.status_code, rsp.text)
+        try:
+            error = rsp.json()['message']
+            if 'Traceback' in error:
+                error = ('\n---------- REMOTE TRACEBACK ----------\n' + error +
+                         '\n---------- END OF REMOTE TRACEBACK ----------')
+        except (ValueError, TypeError, KeyError):
+            error = rsp.text
+        msg = "Deploy failed ({}):\n{}".format(rsp.status_code, error)
         raise RemoteErrorException(msg)
     except requests.RequestException as exc:
         raise RemoteErrorException("Deploy failed: {}".format(exc))