Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geeklist item subscriptions mis-aligned #6

Open
GregRMitchell opened this issue Oct 22, 2019 · 2 comments
Open

Geeklist item subscriptions mis-aligned #6

GregRMitchell opened this issue Oct 22, 2019 · 2 comments
Assignees

Comments

@GregRMitchell
Copy link

When I go to a geeklist subscription with multiple updated items on the same page, it goes to the oldest update, and is not lined up properly. I think a better behaviour would be to always jump to the top subscription list item.

For example, if item 5 was updated first, but then item 1 and item 10 are updated, the subscription takes me to item 5 and isn't lined up right. I have to go up and then down to see all the updates. If it went to item 1 in that scenario instead, I could just go down through all the updates.

@scraimer
Copy link
Owner

That's a good idea, but it means fighting against BGG's linking system. You see, the link you click on in the subscriptions page links directly to a single item chosen by BGG.

My concern is that it will cause the browser jump around on the page, first showing BGG's choice, and then showing the extension's choice. Or even worse, doing the opposite, which would be much more frustrating.

I'll see what I can do.

@scraimer scraimer self-assigned this Oct 24, 2019
@GregRMitchell
Copy link
Author

Right you are...I was thinking you could just pull the anchor off the URL, but I hadn't looked at it. Probably the two approaches would either be to scroll up the appropriate number of items, or scroll to the top of the page and then scroll to the next item - either way, potentially distracting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants