-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dynamic generation and loading sdf file into gazebo functionality. #14
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
93aba1d
updated python notebook
yaswanth1701 84c7fe5
dynamically generating and loading sdf files into gazebo
yaswanth1701 0a8b4c2
updated csv file results
yaswanth1701 ac4c5fb
minor changes
yaswanth1701 54e5904
minor changes
yaswanth1701 67ac3ca
deleted results
yaswanth1701 c8d2bff
minor changes
yaswanth1701 b6fd5be
minor changes
yaswanth1701 8e2dd25
DART working with model_count
yaswanth1701 b641a61
pulled from upstream
yaswanth1701 e3d3510
changes to world.erb files
yaswanth1701 0c01834
changes to boxes.cc file
yaswanth1701 bfe7fb1
minor changes
yaswanth1701 149dbb3
changes to erb file
yaswanth1701 b138b16
minor changes
yaswanth1701 3c51192
minor changes
yaswanth1701 0fa9180
minor changes
yaswanth1701 2f964e5
added config file for paths
yaswanth1701 4b55528
improved formatting and added suggested changes
yaswanth1701 cdaed64
minor fixes
yaswanth1701 1a0cef7
minor changes
yaswanth1701 117dadd
minor changes
yaswanth1701 3d720cf
suggested changes done
yaswanth1701 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
#define WORLDS_DIR_PATH "@WORLDS_DIR_PATH@" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -184,4 +184,4 @@ | |
}, | ||
"nbformat": 4, | ||
"nbformat_minor": 5 | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not for formatting the
dt
value, I would recommend using astringstream
instead ofboost::format
as I find it more readable to have the values expressed inline. It's too badboost::format
doesn't use the same formatting syntax as the c++20 formatting library.We intentionally avoid using boost in
gz-*
libraries. Since gazebo-classic is already using boost, I think it's fine here, but we may want to avoid it when integrating with the newer gazeboThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see, I was using boost because it was already being used by gazebo classic. I will make sure to stick to
stringstream
for newer gazebo.