Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft: validate watch files #37

Closed
wants to merge 1 commit into from
Closed

First draft: validate watch files #37

wants to merge 1 commit into from

Conversation

gaku-sei
Copy link
Contributor

@gaku-sei gaku-sei commented Aug 6, 2021

Closes #36

Revalidates project on file change. Notice that since notify (the library we use for watching/executing) doesn't support globs the user must provide the path twice (also, they could be different and in the future I think it would make sense to accept a list of -w or to have it in a config file (#35)).

Seems to work well and the dev experience even on large projects (~5000 files of ~650 lines each) is smooth.

Some things to improve:

  • Code (it's a bit rough and basically copied from the generate command)
  • Ownership is not good (we send arc here and there, clone them when not needed, watch path is not computed when it should etc...)
  • Not exit on file rename (except the file is the css file), just keep going
  • Better error handling

@gaku-sei gaku-sei added the WIP label Aug 6, 2021
@gaku-sei
Copy link
Contributor Author

Closed by #40

@gaku-sei gaku-sei closed this Aug 10, 2021
@gaku-sei gaku-sei deleted the validate-watch branch August 10, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch mode
1 participant