make shorten api #5
Open
+145
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttexan1
reviewed
Dec 26, 2019
src/adapters/web/middleware.go
Outdated
| @@ -12,6 +12,8 @@ func (web *Web) authenticate(h http.HandlerFunc) http.HandlerFunc { | |||
| return func(w http.ResponseWriter, r *http.Request) { | |||
| session, _ := web.store.Get(r, "scvl") | |||
| userID, ok := session.Values["user_id"].(uint) | |||
| userID = 1 | |||
| ok = true | |||
ttexan1
reviewed
Dec 26, 2019
src/engine/page.go
Outdated
Comment on lines
109
to
112
| _, err = e.sqlClient.FindUserByAPIKey(req.APIKey) | ||
| if err != nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
if _, err = e.sqlClient.FindUserByAPIKey(req.APIKey); err != nil {
return
}
ttexan1
reviewed
Dec 26, 2019
src/engine/page.go
Outdated
Comment on lines
118
to
121
| err = e.sqlClient.CreatePage(page) | ||
| if err != nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
if err = e.sqlClient.CreatePage(page); err != nil {
return
}
ttexan1
reviewed
Dec 26, 2019
src/engine/page.go
Outdated
| } | ||
|
|
||
| page = &domain.Page{ | ||
| Slug: domain.GenerateSlug(5), |
ttexan1
reviewed
Dec 26, 2019
src/adapters/web/web.go
Outdated
| @@ -36,6 +36,8 @@ func (web *Web) Start(port string) error { | |||
| r.Handle("/", web.authenticate(web.rootHandler)).Methods(http.MethodGet) | |||
| r.Handle("/logout", web.authenticate(web.logoutHandler)).Methods(http.MethodPost) | |||
| r.Handle("/shorten", web.authenticate(web.shortenHandler)).Methods(http.MethodPost) | |||
| r.HandleFunc("/api/shorten", web.shortenByAPIHandler).Methods(http.MethodPost) | |||
| r.Handle("/api/publish", web.authenticate(web.publishAPIKeyHandler)).Methods(http.MethodPost) | |||
There was a problem hiding this comment.
path名がこれだと(keyではなく)apiをpublishすることになりそう。
あと、RestでURLを考える場合は基本的に何をするかはAction(get post put delete)で定義されているから、Path中に動詞を入れると冗長になると言われている。
例えば /api/key とかの方がいいかも
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.