Add in scalafmt and scalafix. #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was going to wait to do this, but I was starting on something else in here and I kept hitting format by habit since I'm honestly just used to always having it. I think it's safe to say that most Scala developers will be used to the default style that scalafmt gives you, so I'd like to propose that we add this in along with scalafix to organize imports. One huge concern is always that changes like this make it hard to get a good `git blame`, however with modern git, this really isn't an issue anymore. You can read more about his here: https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame I recently used the strategy outlined in that article in the sbt-scoverage plugin: scoverage/sbt-scoverage#351 and it seems to work quite well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to wait to do this, but I was starting on something else in
here and I kept hitting format by habit since I'm honestly just used to
always having it. I think it's safe to say that most Scala developers
will be used to the default style that scalafmt gives you, so I'd like
to propose that we add this in along with scalafix to organize imports.
One huge concern is always that changes like this make it hard to get a
good
git blame, however with modern git, this really isn't an issueanymore. You can read more about his here:
https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame
I recently used the strategy outlined in that article in the
sbt-scoverage plugin:
scoverage/sbt-scoverage#351 and it seems to work
quite well.
I'll leave this open for now just to see if there is any opposition from any interested
parties. If not, I'll merge this is and follow it up with a pr introducing a
.git-blame-ignore-revswhich can then be used to locally ignore the entire commit when using
git blame. Thenwe won't lose any usefulness of the blame.