Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt, scripted-plugin to 1.5.3 #355

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

scala-steward
Copy link
Contributor

Updates

from 1.5.2 to 1.5.3.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt" } ]

labels: library-update, semver-patch

@scottrice10
Copy link

Anything blocking this from getting merged?

@ckipp01
Copy link
Member

ckipp01 commented Jun 4, 2021

Nothing blocking @scottrice10, but this also shouldn't really make any large difference in the plugin at all.

@ckipp01 ckipp01 merged commit 99c4822 into scoverage:main Jun 4, 2021
@scottrice10
Copy link

but this also shouldn't really make any large difference in the plugin at all.

For projects using the plugin sbt-scoverage, our experience is that those projects cannot update their sbt version - in this case to 1.5.3 - until this plugin is also updated. Is that off base?

@ckipp01
Copy link
Member

ckipp01 commented Jun 4, 2021

but this also shouldn't really make any large difference in the plugin at all.

For projects using the plugin sbt-scoverage, our experience is that those projects cannot update their sbt version - in this case to 1.5.3 - until this plugin is also updated. Is that off base?

That shouldn't be the case at all. The only reason that may happen would be in the actual scalac-scoverage-plugin version that the sbt plugin includes isn't yet published for that version of Scala. The version of Scala that the actual plugin is built in shouldn't have any effect on you.

@scottrice10
Copy link

The only reason that may happen would be in the actual scalac-scoverage-plugin version that the sbt plugin includes isn't yet published for that version of Scala.

Yep, I was confused. scoverage/scalac-scoverage-plugin#352 was the PR I needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants