bug fix - log files were not removed. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change "DateUtil.MILLIS_PER_DAY * conf.log_keep_days" to conf.log_keep_days for DateUnit calculation
|
Thank you for your pull request. |
|
I submitted my CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that previous scouter log files were not removed.
Scouter compare DataUnit for file deletion.
But comparing condition has Big value because it multiply DateUtil.MILLIS_PER_DAY with conf.log_keep_days.
체크 로직에 일수로 비교하게 되어 있는데 파일 삭제 전 비교 로직에서 conf.log_keep_days와 DateUtil.MILLIS_PER_DAY를 곱하게 되어 있어 정상적으로 scouter 로그 파일이 삭제되지 않는 현상을 발견했습니다.
수정 후 pull request합니다.