Pass metadata with requests #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschneid
reviewed
Aug 19, 2019
| { | ||
| parent::__construct($agent); | ||
|
|
||
| // Construct and stop the timer to use its timestamp logic. This event | ||
| // is a single point in time, not a range. | ||
| $this->timer = new Timer(); | ||
| $this->timer->stop(); | ||
| $this->timer = new Timer((float) $now->format('U.u')); |
There was a problem hiding this comment.
Is this explicit $now just for testing?
There was a problem hiding this comment.
Primarily yes; time is global state, so converting to use a defined time-stamp.in tests is always going to be a win. I've lost count of the number of tests I've discovered were flaky due to assumptions about date/time 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metadata into the requests made.
Currently, it's difficult to test this, as we cannot inject dependencies, so have no way to "fake" the server. I'll look at refactoring and fixing this separately as it's not strictly related.