Fix X-Request-Start header when added to server #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P_* keys Previously only $_SERVER values prefixed with HTTP_ (i.e. HTTP headers) were returned; I updated this as in some cases (e.g. with nginx configuration) the X-Request-Start header value may be set directly into $_SERVER, rather than being prefixed (such as how Apache does by default). This makes the header checking more flexible and less fussy to configure.
asgrim
force-pushed
the
fix-x-request-start-header-when-added-to-server
branch
from
70a444a to
ddd264b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
Previously only
$_SERVERvalues prefixed withHTTP_(i.e. HTTP headers) were returned; I updated this as in some cases (e.g. with nginx configuration) theX-Request-Startheader value may be set directly into$_SERVER, rather than being prefixed (such as how Apache does by default). This makes the header checking more flexible and less fussy to configure.