Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing env in CI #178

Merged
merged 4 commits into from
May 28, 2020
Merged

Fix missing env in CI #178

merged 4 commits into from
May 28, 2020

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented May 27, 2020

Since some tests use a special environment variable SCOUT_APM_KEY (named differently on purpose), we need to import this as a "secret" key (see https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets ).

This needs to be added by @cschneid in the settings before it'll work however...

(relates to #177)

@asgrim asgrim self-assigned this May 27, 2020
@asgrim asgrim added the enhancement New feature or request label May 27, 2020
@asgrim asgrim added this to the 4.4.0 milestone May 27, 2020
@asgrim asgrim merged commit eb38e61 into master May 28, 2020
@asgrim asgrim deleted the ci-fix-env branch May 28, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant