Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made framework and framework version come from configuration #150

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Made framework and framework version come from configuration #150

merged 1 commit into from
Dec 19, 2019

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Dec 19, 2019

Fixes #147

@asgrim asgrim added the enhancement New feature or request label Dec 19, 2019
@asgrim asgrim added this to the 3.0.1 milestone Dec 19, 2019
@asgrim asgrim requested a review from cschneid December 19, 2019 16:11
@cschneid
Copy link
Contributor

Does this have a matching scout-apm-laravel change to have it set this config?

@cschneid cschneid merged commit 32ca024 into master Dec 19, 2019
@asgrim asgrim deleted the make-framework-configurable branch December 19, 2019 16:35
@asgrim
Copy link
Collaborator Author

asgrim commented Dec 19, 2019

I created issues, see:

This was referenced Dec 23, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschneid cschneid cschneid approved these changes

Assignees

@cschneid cschneid

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Framework is hardcoded in metadata
2 participants
@asgrim @cschneid