Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose new ScoutApmAgent endpoint to start a new request #148

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Expose new ScoutApmAgent endpoint to start a new request #148

merged 2 commits into from
Dec 18, 2019

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Dec 18, 2019

Needed to implement scoutapp/scout-apm-laravel#35 properly.

@asgrim asgrim added enhancement New feature or request WIP Work in progress - do not merge BC BREAK This PR contains a BC break; major version should be incremented labels Dec 18, 2019
@asgrim asgrim self-assigned this Dec 18, 2019
@asgrim asgrim requested a review from cschneid December 18, 2019 12:00
@asgrim asgrim assigned cschneid and unassigned asgrim Dec 18, 2019
@asgrim
Copy link
Collaborator Author

asgrim commented Dec 18, 2019

@cschneid I need your approval on this one since it's a definite BC break - would break downstream consumers using ScoutApmAgent interface (e.g. mocking for tests etc.)

@asgrim asgrim removed the WIP Work in progress - do not merge label Dec 18, 2019
@cschneid cschneid merged commit eae10f9 into master Dec 18, 2019
@asgrim asgrim deleted the added-start-new-request-endpoint branch December 19, 2019 08:33
@asgrim asgrim added this to the 2.1.2 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschneid cschneid cschneid approved these changes

Assignees

@cschneid cschneid

Labels
BC BREAK This PR contains a BC break; major version should be incremented enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@asgrim @cschneid