Updates CoreAgent to 1.2.4 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few bug fixes, but most notable fix is better parsing/naming of SQL emitted in real-life by Laravel. So instead of having "SQL" as the name of the row in the web UI, it will say "User/Select" or "Post/Update" and so on more often. Note: it wasn't skipping any instrumented SQL previously, just was falling back to a generic name for it.
|
@cschneid please can you add to the changelog too? |
|
Also there's a 404 for the URL, is it published yet? |
|
It is not yet published, will be up in a few. |
|
Ok, core agent should be published now, and download URL live. |
asgrim
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few bug fixes, but most notable fix is better parsing/naming of SQL
emitted in real-life by Laravel. So instead of having "SQL" as the name
of the row in the web UI, it will say "User/Select" or "Post/Update" and
so on more often.
Note: it wasn't skipping any instrumented SQL previously, just was
falling back to a generic name for it.