Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for PHPunit deprecations #203

Open
asgrim opened this issue Feb 10, 2021 · 0 comments
Open

Fixes for PHPunit deprecations #203

asgrim opened this issue Feb 10, 2021 · 0 comments
Assignees
@asgrim
Labels
enhancement New feature or request

Comments

@asgrim
Copy link
Collaborator

asgrim commented Feb 10, 2021

The following items will be removed in phpunit 10, so we should look into alternatives:

at(n)

self::at(n) is currently in use and should be replaced (see sebastianbergmann/phpunit#4297)

In most cases, withConsecutive and/or willReturnOnConsecutiveCalls should be used.

assertRegExp

See sebastianbergmann/phpunit#4086

assertRegExp should be replaced with assertMatchesRegularExpression

TestListener

Test listeners (as used in \Scoutapm\IntegrationTests\CheckScoutApmKeyListener) are deprecated, \PHPUnit\Runner\TestHook should be used instead. Need to investigate whether \PHPUnit\Runner\TestHook is available when running older phpunits (compatible with PHP 7.1) - polyfill or some workaround may be necessary if not.
@asgrim asgrim added the enhancement New feature or request label Feb 10, 2021
@asgrim asgrim self-assigned this Feb 10, 2021
asgrim added a commit that referenced this issue Feb 10, 2021
@asgrim
Temporarily ignore phpunit deprecations since we have an issue to fix…
f628c88 
… later in #203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asgrim asgrim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asgrim