(#396) Fixed unwated behaviour of files and filesOpts while not uploading file. #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not uploading any file.
ocramz
requested changes
Apr 30, 2024
| let | ||
| fs' = filter emptyFile fs | ||
| return (convertBoth <$> formparams, convertKey <$> fs') | ||
| where emptyFile (_,fInfo) = ("\"\"" /= (W.fileName fInfo)) |
There was a problem hiding this comment.
How do HTML forms behave if the name attribute is absent? i.e. how does the payload sent by the browser look like.
There was a problem hiding this comment.
Hi @ocramz,
I will add the test-cases.
payload when I upload style.css file with name attribute in HTML.
Payload when I upload style.css file without name attribute in HTML.
|
@ocramz, I have added the test-cases. |
|
@tusharad since this change would break users of many versions of scotty (for good or worse: users will rely on every observable feature of a software), maybe it's a good idea to review how other web frameworks behave with empty files input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please visit issue #396 for more details.
Issue
When using
filesorfilesOptsfunction, upon not uploading any file, these function would still return a list of tuples containing filename as"\"\""and fileContent as"\"\"".Solution
parseRequestBodyExBSwhich converts the body into the list of FileInfo type, that will remove any file whose filename is"\"\"".changelog.mdunderbreaking changesas well.Thanks.