Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for 'defaultHandler unsets actionErrorHandler' (#339) #356

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Add test for 'defaultHandler unsets actionErrorHandler' (#339) #356

merged 1 commit into from
Dec 16, 2023

Conversation

jedimahdi
Copy link
Contributor

Closes #339

@ocramz
Copy link
Collaborator

ocramz commented Dec 7, 2023

Thank you @jedimahdi !

@ocramz ocramz self-requested a review December 8, 2023 21:06
ocramz
ocramz approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@ocramz ocramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test/Web/ScottySpec.hs
let h = Handler (\(_ :: E.SomeException) -> setHeader "Location" "/c" >> status status500)
defaultHandler h
Scotty.get "/a" (redirect "/b")) $ do
it "should give priority to actionErrorHandlers" $ do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actionErrorHandler, singular :)

@ocramz ocramz merged commit f3366ad into scotty-web:master Dec 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocramz ocramz ocramz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for 'defaultHandler unsets actionErrorHandler'
2 participants
@jedimahdi @ocramz