Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): Allow newlines inside import groups #7

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core.js
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,8 @@ module.exports = {
// documented default is not correct, specifying manually
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md#options
'import/order': ['error', {
groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
'groups': ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
'newlines-between': 'always-and-inside-groups',
}],
'import/prefer-default-export': 'error',

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@
"commitmsg": "validate-commit-msg"
},
"dependencies": {
"@scottnonnenberg/eslint-plugin-thehelp": "0.3.2",
"eslint": "2.11.1",
"eslint-plugin-bdd": "2.1.0",
"eslint-plugin-chai-expect": "1.1.1",
"eslint-plugin-filenames": "1.0.0",
"eslint-plugin-immutable": "1.0.0",
"eslint-plugin-import": "1.8.0",
"eslint-plugin-import": "2.7.0",
"eslint-plugin-jsx-a11y": "1.2.3",
"eslint-plugin-no-loops": "0.2.0",
"eslint-plugin-react": "5.1.1",
"eslint-plugin-security": "1.2.0",
"@scottnonnenberg/eslint-plugin-thehelp": "0.3.2"
"eslint-plugin-security": "1.2.0"
},
"devDependencies": {
"eslint-find-rules": "1.10.0",
Expand Down
1 change: 1 addition & 0 deletions test/react_combined.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
var _ = require('lodash');

var react = require('../react');

var start = require('./index_combined');


Expand Down
1 change: 1 addition & 0 deletions test/test_combined.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
var _ = require('lodash');

var test = require('../test');

var start = require('./index_combined');


Expand Down