-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config file for more flexible http server setup #133
Labels
Comments
scottlamb
added a commit
that referenced
this issue
Mar 10, 2022
scottlamb
added a commit
that referenced
this issue
Mar 10, 2022
scottlamb
added a commit
that referenced
this issue
Mar 16, 2022
* switch from json to toml. I think this will be more user-friendly. It allows comments and has less punctuation. Fewer surprises than yaml (which has e.g. the "Norway problem"). I might have stayed with JSON if I could see a good serde json library that allows comments, but hson is unmaintained and serde-json strictly follows the spec. * switch from camelCase to snake_case. Seems more idiomatic for TOML and matches the Rust source. * forbid unknown keys. Better to spot errors sooner. * rename "trust_forward_hdrs" to "trust_forward_headers". Nothing else is abbreviated.
scottlamb
added a commit
that referenced
this issue
Mar 16, 2022
The crux of this issue is done: there is a config file format with a |
Oops, mentioned the wrong issue in that commit. Reopening this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context: this comment on #132, #35 , #27, #31 .
It'd be nice to have more than a single
--http-addr=ipaddr:port
and allow them to differ in configuration (different--allow-unauthenticated-permissions
,--trust-forward-hdrs
, etc). I think it's cheap to have severalhyper::Server
s in the process. Eg, I'd like to run my server in the following configuration:https
proxy server. It requires authentication and trusts theX-Real-IP
andX-Forwarded-For
headers. (I probably should also a header from the proxy with a shared secret to avoid being insecure on accidental misconfiguration.)moonfire-nvr login
expects now) or to have already created and stored session cookie.Another use: Bobberty just mentioned wanting an IPv4 binding + a IPv6 binding.
Per-bind address knobs might grow to include:
FileDescriptorName=
andsd_listen_fds_with_names
.]SO_PEERCRED
-based uid authentication rather just trusting the peer. (Theuser
table has long had aunix_uid
for this but it's unimplemented.)--allow-unauthenticated-permissions
--trust-forward-hdrs
, with the additional ability to configure a shared secret as mentioned abovehttps
: letsencrypt challenge config or supplied certificate file paths.Seems way too awkward to specify all the stuff above on the commandline, and I don't think it belongs well in the database (I don't want to add a configuration tool for it and folks are used to configuration files for stuff like this), so I think we should introduce a config file. toml, text proto, json, yaml, something like that.
The text was updated successfully, but these errors were encountered: