Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #60 - Multiple SWAP's breaks output #61

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

Mai-Lapyst
Copy link
Contributor

DOOL VERSION

Dool 1.3.0

SUMMARY

Removes the hardcoded self.name = 'swap' line from the dool_swap plugin.
This has the fixes the broken output and calls def name(self) correctly.

This might be a breaking change, since the name changes from swap to swp/total, when only using --swap without --full or a custom -S.

Before:

$ dool --epoch --swap -S /dev/sdb4,/dev/sda4,total --aio
┄┄epoch┄┄┄┬┄┄┄┄swap┄┄┄┬async
  epoch   │ used  free│ #aio
1699676083│   0    10G┊   0    10G┊   0    20G│ 576B
1699676084│   0    10G┊   0    10G┊   0    20G│ 576B

$ dool --epoch --swap --aio
┄┄epoch┄┄┄┬┄┄┄┄swap┄┄┄┬async
  epoch   │ used  free│ #aio
1699676029│   0    20G│ 576B
1699676030│   0    20G│ 576B

After:

$ dool --epoch --swap -S /dev/sdb4,/dev/sda4,total --aio
┄┄epoch┄┄┄┬┄┄swp/sdb4┄┄┄┄swp/sda4┄┄┄swp/total┄┬async
  epoch   │ used  free  used  free  used  free│ #aio
1699676353│   0    10G┊   0    10G┊   0    20G│ 576B
1699676354│   0    10G┊   0    10G┊   0    20G│ 576B

$ dool --epoch --swap --aio                             
┄┄epoch┄┄┄┬┄swp/total┄┬async
  epoch   │ used  free│ #aio
1699676376│   0    20G│ 576B
1699676377│   0    20G│ 576B

@scottchiefbaker scottchiefbaker merged commit 89e598f into scottchiefbaker:master Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants