User endpoint tests #888
Open
User endpoint tests #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JaDogg this is a draft PR. Should I refactor the rest of the tests in the same way? Your inputs are highly welcome. |
JaDogg
reviewed
Feb 15, 2020
| 'Content-Type': 'application/x-www-form-urlencoded', | ||
| 'Origin': 'http://localhost:3000', | ||
| } | ||
| user_data = { |
There was a problem hiding this comment.
Will we need to load these passwords/user_names from a config?
There was a problem hiding this comment.
Right now these are just present in this file itself in future I will create a config to store this data.
JaDogg
approved these changes
Feb 15, 2020
Comment on lines
+3
to
+4
| import logging as logger | ||
| from flask import g |
There was a problem hiding this comment.
Are these imports used? If not let's remove these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added tests for User endpoints and fixed bug in UserManager.py to allow user to be deleted through the endpoint.
Related Issue #851
Motivation and Context
Tests should be present to allow the project maintainers to know that the endpoints arae working correctly.
How Has This Been Tested?
Screenshots (In case of UI changes):
Types of changes
Checklist: