Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

production dockerfile for frontend-react #855

Merged
merged 1 commit into from
Mar 21, 2020
Merged

production dockerfile for frontend-react #855

merged 1 commit into from
Mar 21, 2020

Conversation

selfisekai
Copy link

Description

a dockerfile to build the frontend and an nginx server to serve it

Related Issue

Google Code-In 2019 task

Motivation and Context

How Has This Been Tested?

  • docker build .
  • docker run [image id]
  • run the page in Firefox browser

Screenshots (In case of UI changes):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JaDogg JaDogg requested review from JaDogg and kmehant January 4, 2020 17:57
@kmehant
Copy link
Collaborator

kmehant commented Mar 19, 2020

@JaDogg Shall we merge this?

@JaDogg JaDogg merged commit a473a5d into scorelab:develop Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmehant kmehant kmehant approved these changes

@JaDogg JaDogg JaDogg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@selfisekai @kmehant @JaDogg