Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix builds #835

Merged
merged 1 commit into from
Dec 10, 2019
Merged

fix builds #835

merged 1 commit into from
Dec 10, 2019

Conversation

selfisekai
Copy link

reopening #834 because I messed up

Description

  • upgrading the version of mysqlclient module
  • adding the required minio module at the latest version

Related Issue

#832

Motivation and Context

fixing the builds

How Has This Been Tested?

ran server with docker-compose --file docker-compose.dev.yml up api (with proper env values)

Screenshots (In case of UI changes):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@selfisekai selfisekai mentioned this pull request Dec 7, 2019
Closed
8 tasks
@kmehant
Copy link
Collaborator

kmehant commented Dec 8, 2019

@selfisekai No worries be careful from next time when you are working with feature branches.

@kmehant kmehant requested a review from JaDogg December 8, 2019 01:57
kmehant
kmehant approved these changes Dec 8, 2019
View reviewed changes
Copy link
Collaborator

@kmehant kmehant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ACK.

@kmehant kmehant merged commit 58d2e3c into scorelab:develop Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmehant kmehant kmehant approved these changes

@JaDogg JaDogg JaDogg approved these changes

Assignees
No one assigned
Labels
GoogleCodeIn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@selfisekai @kmehant @JaDogg